Skip to content

musa: upgrade musa sdk to rc4.2.0 #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Conversation

yeahdongcn
Copy link
Contributor

@yeahdongcn yeahdongcn commented Jul 16, 2025

This will require syncing with the latest changes from ggml once ggml-org/llama.cpp#14498 is merged.

Testing Done

docker build -t sd-musa -f Dockerfile.musa .

@yeahdongcn yeahdongcn changed the title musa: upgrade musa sdk to 4.2.0 musa: upgrade musa sdk to rc4.2.0 Jul 24, 2025
@yeahdongcn yeahdongcn marked this pull request as ready for review July 24, 2025 02:05
@leejet
Copy link
Owner

leejet commented Jul 24, 2025

Is rc4.2.0 required to wait for the merge of ggml's PR?

@yeahdongcn
Copy link
Contributor Author

Is rc4.2.0 required to wait for the merge of ggml's PR?

Yes, though I'm not familiar with stable-diffusion.cpp's strategy for syncing ggml. I’ll ping you once my changes are merged into ggml.

@yeahdongcn
Copy link
Contributor Author

yeahdongcn commented Jul 28, 2025

@leejet It appears that ggml (master branch) now includes my changes. Starting from commit d1f98530dc94469b5ccc8b7c8eff8a408dd82311, things should be working as expected.

@leejet leejet merged commit 8c3c788 into leejet:master Jul 28, 2025
@leejet
Copy link
Owner

leejet commented Jul 28, 2025

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants