Fixes folders or resources with missing title remain 'incomplete' after editing just the title #5539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolson
reviewed
Nov 7, 2025
| : ''; | ||
| }, | ||
| error() { | ||
| if (!this.node.complete) { |
Member
There was a problem hiding this comment.
It’s a bit unclear to me why this check is being removed. It appears to validate whether the node is incomplete. I think our investigation should focus on understanding why the node becomes marked as incomplete after updating the title (and possibly other fields). Removing this validation check would only mask the issue and prevent us from detecting when a node is actually incomplete. Am I missing something?
Member
There was a problem hiding this comment.
A good place would be to understand what is going on in the isNodeComplete function
akolson
requested changes
Nov 7, 2025
Member
akolson
left a comment
akolson
left a comment
There was a problem hiding this comment.
Hi @AllanOXDi! I left a general comment about the implementation. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes folders or resources with missing title remain 'incomplete' after editing just the title
Closes #5347
References
#5347
Before
2025-09-01_17-24-52.mp4
After
Screen.Recording.2025-11-06.at.18.45.55.mov
Reviewer guidance