-
Notifications
You must be signed in to change notification settings - Fork 250
[Remove Vuetify from Studio] Content Library Catalog - Frequently asked questions page #5517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
I found a broken link while testing. |
|
Thanks for your continued work @yeshwanth235, very high-level, it's aligned with expectations. We will assign someone for a detailed review next week. |
|
@yeshwanth235 Could you merge latest |
|
And thanks for reporting the link, I will find out where it was supposed to go. |
|
@yeshwanth235 as for the broken link, the right target for now will be |
Updated the link @MisRob. I have taken care |
akolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yeshwanth235! Great work on this PR. Could you please take some time to implement the accessibility requirements outlined in the issue? It looks like they haven’t been addressed yet. Once that’s done, I’ll be able to do a more comprehensive review of the changes as a whole. Thanks!

Summary
Removed all Vuetify components and migrated to KDS components in /faq
Created StudioAccordion and StudioAccordionItem for accordion.
Video: link
References
Fixes 5502
Reviewer guidance
Need full page testing for /faq in web and mweb