Skip to content

Improve discovery of preview in kolibri for guest users #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: unstable
Choose a base branch
from

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Apr 30, 2025

Summary

  • Change UI according the following figma design.
    channel cards studio
  • Implements a sidePanel for a preview of channels.
  • Dynamically change icons and buttons for guest and logged-in users.
changes1.mp4
changes2.mp4

References

closes #3083

Reviewer guidance

  • Test all the possible permutations with demo URL and source URL set and unset.
  • The Icons and side panel should match the designs attached above.

@rtibbles rtibbles self-assigned this May 6, 2025
@ozer550 ozer550 force-pushed the improve-discovery-of-preview-in-kolibri-for-guest-users branch from fd55b85 to 4ef719a Compare May 12, 2025 05:21
/>
<ChannelStar
v-if="loggedIn"
:channelId="channelId"
:bookmark="channel.bookmark"
class="mr-1"
/>
<BaseMenu v-if="showOptions">

<BaseMenu v-if="iconConfigs.find(config => config.key === 'kebab-menu')?.show">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging that we can't use the conditional chaining operator in vue templates at the moment - so will need to tweak this - can move to a computed prop if that's easier.

This should fix the test failures.

@ozer550 ozer550 marked this pull request as ready for review May 23, 2025 10:40
@ozer550 ozer550 requested a review from rtibbles May 23, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design improvement: Discovery of "preview in Kolibri" action in Catalog
3 participants