Fix perf result script error handling #472
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
duplicated by #471 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 11 11
Lines 357 357
Branches 116 127 +11
=======================================
Hits 329 329
Misses 10 10
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aobolensk
deleted the
codex/modify-generate_perf_results.sh-for-strict-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
generate_perf_results.shto fail fast on errors or unset variablesTesting
python3 scripts/run_tests.py --running-type=threads(fails: Required environment variable 'PPC_NUM_THREADS' is not set)pip install flake8(fails: Could not find a version that satisfies the requirement flake8)https://chatgpt.com/codex/tasks/task_e_685981d1a328832fade35d9a0618f626