Skip to content

Apply gtest_force_shared_crt for MSVC only #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

aobolensk
Copy link
Member

@aobolensk aobolensk commented Jun 23, 2025

Enable gtest_force_shared_crt only when using MSVC via a generator expression

@aobolensk aobolensk changed the title Conditionally apply gtest_force_shared_crt Apply gtest_force_shared_crt for MSVC only Jun 23, 2025
@aobolensk aobolensk enabled auto-merge June 23, 2025 13:03
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (6c1e33c) to head (513db04).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files          11       11           
  Lines         357      357           
  Branches      127      127           
=======================================
  Hits          329      329           
  Misses         10       10           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aobolensk aobolensk added this pull request to the merge queue Jun 23, 2025
Merged via the queue into master with commit e065612 Jun 23, 2025
76 checks passed
@aobolensk aobolensk deleted the codex/modify-cmake/gtest.cmake-for-msvc branch June 24, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant