Convert all scripts #306
Merged
Convert all scripts #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
allnes
commented
Feb 7, 2025
•
allnes
commented
- Convert all scripts (exception - perf generator)
- Separate windows builds and tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 26 26
Lines 479 479
Branches 143 143
=======================================
Hits 450 450
Misses 14 14
Partials 15 15 ☔ View full report in Codecov by Sentry. |
allnes
force-pushed
the
an/convert_scripts
branch
from
ae08291 to
dced792
Compare
This was
linked to
issues
Feb 8, 2025
allnes
force-pushed
the
an/convert_scripts
branch
from
6843cf4 to
bdf721e
Compare
allnes
force-pushed
the
an/convert_scripts
branch
from
bdf721e to
4a9306b
Compare
aobolensk
requested changes
Feb 8, 2025
scripts/run_perf_counter.py
Outdated
| pattern = r".*all\.|.*_mpi.|.*_omp.|.*_seq.|.*_stl.|.*_tbb." | ||
| test_matches = [test_name for test_name in tests_list if re.match(pattern, test_name)] | ||
| if len(tests_list) != 3 * len(test_matches): | ||
| raise Exception(f"Count of all test {len(tests_list)} != count of theoretical count test {len(test_matches)}.") |
There was a problem hiding this comment.
Should that be multiplied by 3 in the message as well?
scripts/run_tests.py
Outdated
| self.ocv_script_path = "build/ppc_opencv/install/" + self.ocv_script_name | ||
| else: | ||
| self.ocv_script_name = "setup_vars_opencv4.sh" | ||
| self.ocv_script_path = "build/ppc_opencv/install/bin/" + self.ocv_script_name |
Co-authored-by: Arseniy Obolenskiy <[email protected]>
Co-authored-by: Arseniy Obolenskiy <[email protected]>
Co-authored-by: Arseniy Obolenskiy <[email protected]>
aobolensk
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.