Skip to content

Convert all scripts - #306

Merged
allnes merged 20 commits into
learning-process:masterfrom
allnes:an/convert_scripts
Feb 8, 2025
Merged

allnes merged 20 commits into
learning-process:masterfrom
allnes:an/convert_scripts

Conversation

@allnes

@allnes allnes commented Feb 7, 2025 •

Copy link
Copy Markdown
Member
  • Convert all scripts (exception - perf generator)
  • Separate windows builds and tests

@codecov

codecov Bot commented Feb 7, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (f1d983a) to head (61d2c6d).
Report is 55 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          26       26           
  Lines         479      479           
  Branches      143      143           
=======================================
  Hits          450      450           
  Misses         14       14           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allnes allnes linked an issue Feb 7, 2025 that may be closed by this pull request
@allnes
allnes force-pushed the an/convert_scripts branch from 6843cf4 to bdf721e Compare February 8, 2025 02:54
@allnes
allnes force-pushed the an/convert_scripts branch from bdf721e to 4a9306b Compare February 8, 2025 03:25
@allnes
allnes marked this pull request as ready for review February 8, 2025 03:59
@allnes
allnes requested a review from aobolensk February 8, 2025 03:59
@allnes allnes self-assigned this Feb 8, 2025
Comment thread scripts/run_perf_counter.py Resolved
Comment thread scripts/run_perf_counter.py Resolved
Comment thread scripts/run_perf_counter.py Outdated
pattern = r".*all\.|.*_mpi.|.*_omp.|.*_seq.|.*_stl.|.*_tbb."
test_matches = [test_name for test_name in tests_list if re.match(pattern, test_name)]
if len(tests_list) != 3 * len(test_matches):
raise Exception(f"Count of all test {len(tests_list)} != count of theoretical count test {len(test_matches)}.")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be multiplied by 3 in the message as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aobolensk corrected

Comment thread scripts/run_tests.py Resolved
Comment thread scripts/run_tests.py Outdated
self.ocv_script_path = "build/ppc_opencv/install/" + self.ocv_script_name
else:
self.ocv_script_name = "setup_vars_opencv4.sh"
self.ocv_script_path = "build/ppc_opencv/install/bin/" + self.ocv_script_name

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Path

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aobolensk corrected

allnes and others added 4 commits February 8, 2025 13:36
Co-authored-by: Arseniy Obolenskiy <gooddoog@student.su>
Co-authored-by: Arseniy Obolenskiy <gooddoog@student.su>
Co-authored-by: Arseniy Obolenskiy <gooddoog@student.su>
@allnes
allnes requested a review from aobolensk February 8, 2025 12:54
@aobolensk
aobolensk enabled auto-merge February 8, 2025 13:00
@allnes
allnes disabled auto-merge February 8, 2025 13:48
@allnes
allnes merged commit fca26a9 into learning-process:master Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows threads-processes separate Extract build as a separate step and reuse on the test stage on Windows Convert all scripts to py

2 participants