Skip to content

Make clang-tidy rules more strict #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

aobolensk
Copy link
Member

No description provided.

@aobolensk aobolensk self-assigned this Jan 6, 2025
@aobolensk aobolensk force-pushed the clang-tidy-strict-2 branch from 6e98253 to 2587570 Compare January 6, 2025 17:30
@aobolensk aobolensk force-pushed the clang-tidy-strict-2 branch from 2587570 to ea58f97 Compare January 6, 2025 19:44
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.75%. Comparing base (760d2d3) to head (a1363e8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/perf/src/perf.cpp 91.66% 0 Missing and 2 partials ⚠️
modules/core/task/src/task.cpp 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   96.72%   96.75%   +0.02%     
==========================================
  Files          33       33              
  Lines         581      585       +4     
  Branches      170      174       +4     
==========================================
+ Hits          562      566       +4     
  Misses          2        2              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allnes
Copy link
Member

allnes commented Jan 6, 2025

@aobolensk decrease test coverage

@aobolensk
Copy link
Member Author

@aobolensk decrease test coverage

This patch is NFC (non-functional change). This is a problem of reporting

@allnes allnes merged commit 32d76a7 into learning-process:master Jan 6, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants