fix: make printed page look somewhat decent #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nav bar took up a lot of space even though it wasn't displayed. I also got rid of the header while I was there. Some code snippets were printed with a scroll bar instead of wrapping them. Also, footnotes can't float in print note and just looked broken, so I redesigned them as in-line info boxes. They still look a little wonky, but they're a lot better than overlapping digits onto text.
|
Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit a934aed. |
|
Let me know when you're ready for a merge - looks like you're still working on it, so I'll hold off for now. |
|
And thanks, BTW! |
|
Twice so far I've thought I was done, only for idle scrolling through the PDF to reveal some more scroll bars :D I've looked through it once more and found no more scroll bars. Should be ready to merge now. |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nav bar took up a lot of space even though it wasn't displayed. I also got rid of the header while I was there.
Some code snippets were printed with a scroll bar instead of wrapping them. Also, footnotes can't float in print note and just looked broken, so I redesigned them as in-line info boxes. They still look a little wonky, but they're a lot better than overlapping digits onto text.
These changes are the result of my experiments on zulip: #new members > Printable form of language reference? @ 💬
They should help with #434 if one uses a browser to convert the single-page manual to a PDF.