chore: remove the no-longer-referenced ofReduceNat axiom (or add tests for it, depending on feedback)
#7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euprunin
changed the title
ofReduceNat axiom or remove it, depending on CI results and feedbackofReduceNat axiom or remove it, depending on CI results and feedback
euprunin
changed the title
ofReduceNat axiom or remove it, depending on CI results and feedbackofReduceNat axiom or add tests for it, depending on CI results and feedback
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
euprunin
force-pushed
the
euprunin_ofreducenat
branch
from
c0a6f22 to
8b427e5
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 29, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 29, 2025
leanprover-community-bot
added
the
builds-mathlib
euprunin
changed the title
ofReduceNat axiom or add tests for it, depending on CI results and feedbackofReduceNat axiom (or add tests for it, depending on CI results and feedback)
euprunin
changed the title
ofReduceNat axiom (or add tests for it, depending on CI results and feedback)ofReduceNat axiom (or add tests for it, depending on feedback)
|
@arthur-adjedj Thanks for the feedback! Are you suggesting we add a test instead? Could you clarify how this axiom is being used indirectly? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
ofReduceNatis no longer referenced or used anywhere in the codebase. A review of the commit history shows that its last reference was removed in 2021 (see 9f88ea8). Local testing also suggests thatofReduceNatis unused.That said, the presence of an unused axiom is somewhat surprising, and since I’m new to this project there’s a chance I might be missing an indirect usage. If so, please let me know and I’ll either close this PR, or add a proper test for
ofReduceNatdepending on what is deemed the appropriate course of action.I’m submitting it as a draft to ensure everything builds in CI across all configurations. The next step will be to confirm that it also builds Mathlib successfully. Update: Seems to build Mathlib without problems.