Skip to content

chore: enable build-specific documentation roots #7455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

david-christiansen
Copy link
Contributor

This PR enables the use of the build-time configuration of the Lean reference manual URL and updates the release checklist to account for the reference manual.

This is a follow-up to #7240, after the required stage0 update.

The release process described here uses the same location for the reference manual for RCs and stable releases. This is for two reasons:

  1. The only changes between them should be a modification of the embedded version string and updates to the final release's release notes, once those are included.
  2. It ensures that a compatible manual is available at the moment that the new release appears, so any delay getting it deployed won't be visible to users.

This PR enables the use of the build-time configuration of the Lean
reference manual URL and updates the release checklist to account for
the reference manual.

This is a follow-up to leanprover#7240, after the required `stage0` update.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 12, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Mar 12, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d1d2f215adc90e88120f6b4cdda8d264c0e5de00 --onto 8fc8e8ed19ef218022f5a94cbf5e472e3b777e44. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-12 13:30:10)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d1d2f215adc90e88120f6b4cdda8d264c0e5de00 --onto 3d0f41e32321147b19c5a26651e3f0a3c6c0ab6a. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-21 23:17:57)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d1d2f215adc90e88120f6b4cdda8d264c0e5de00 --onto 12a21e79c71880424321d62e60449863c504048a. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-31 08:29:17)

@david-christiansen
Copy link
Contributor Author

@kim-em I think I've got this down to a pretty efficient procedure. I've tested the CMake update locally, and it did what it should.

Thanks for your patience while I got it all set up!

Copy link
Contributor

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-christiansen david-christiansen added this pull request to the merge queue Mar 31, 2025
Merged via the queue into leanprover:master with commit 9753d3c Mar 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants