Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bug in pattern selection heuristic in grind #6892

Merged
merged 3 commits into from
Jan 31, 2025
Merged

feat: bug in pattern selection heuristic in grind #6892

merged 3 commits into from
Jan 31, 2025

Conversation

leodemoura
Copy link
Member

This PR fixes a bug in the pattern selection heuristic used in grind. It was unfolding definitions/abstractions that were not supposed to be unfolded. See grind_constProp.lean for examples affected by this bug.

@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jan 31, 2025
@leodemoura leodemoura enabled auto-merge January 31, 2025 20:01
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 31, 2025 20:09 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jan 31, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 31, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5900f39638b24312bb6c32703a565c3e0b7b0644 --onto ad48761032c5750e51289f3885967c1b6f8edde5. (2025-01-31 20:27:20)

Merged via the queue into master with commit 5286b21 Jan 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot