feat: teach bv_normalize that (x >> x) = 0
#6818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PRs adds a BitVec lemma that `(x >> x) = 0` and plumbs it through to bv_normalize. I also move some theorems I found useful to the top of the ushiftRight section.
|
changelog-library |
github-actions
bot
added
changelog-library
|
Mathlib CI status (docs):
|
hargoniX
reviewed
Jan 28, 2025
hargoniX
requested changes
Jan 28, 2025
hargoniX
approved these changes
Jan 28, 2025
vlad902
added a commit
to vlad902/lean4
that referenced
this pull request
Feb 3, 2025
In leanprover#6818, I removed this small section of reductions from BitVec to Nat since it seemed unnecessary. Since then, I saw that there are equivalent sections for shiftLeft/sshiftRight that are more substantial and that I should have not made this change.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
In #6818, I removed this small section of reductions from BitVec to Nat since it seemed unnecessary. Since then, I saw that there are equivalent sections for shiftLeft/sshiftRight that are more substantial and that I should have not made this change.
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
This PR adds a BitVec lemma that `(x >> x) = 0` and plumbs it through to bv_normalize. I also move some theorems I found useful to the top of the ushiftRight section.
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
In leanprover#6818, I removed this small section of reductions from BitVec to Nat since it seemed unnecessary. Since then, I saw that there are equivalent sections for shiftLeft/sshiftRight that are more substantial and that I should have not made this change.
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
This PR adds a BitVec lemma that `(x >> x) = 0` and plumbs it through to bv_normalize. I also move some theorems I found useful to the top of the ushiftRight section.
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
In leanprover#6818, I removed this small section of reductions from BitVec to Nat since it seemed unnecessary. Since then, I saw that there are equivalent sections for shiftLeft/sshiftRight that are more substantial and that I should have not made this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a BitVec lemma that
(x >> x) = 0and plumbs it through to bv_normalize. I also move some theorems I found useful to the top of the ushiftRight section.