Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify delaborator to tag generalized field notation #6703

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Jan 20, 2025

This PR modifies the delaborator so that in pp.tagAppFns mode, generalized field notation is tagged with the head constant. The effect is that docgen documentation will linkify dot notation. Internal change: now formatted rawIdent can be tagged.

This PR modifies the delaborator so that in `pp.tagAppFns` mode, generalized field notation is tagged with the head constant. The effect is that docgen documentation will linkify dot notation. Internal change: now formatted `rawIdent` can be tagged.
@kmill kmill added the changelog-pp Pretty printing label Jan 20, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 20, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9dbe5e6f9ce6bc686541218f62ff6b8063dfc4dc --onto 74bd40d34d1a969da65007939960c2fefd461f08. (2025-01-20 01:27:42)

@kmill kmill added this pull request to the merge queue Feb 2, 2025
Merged via the queue into leanprover:master with commit 3fb264b Feb 2, 2025
17 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 24, 2025
…r#6703)

This PR modifies the delaborator so that in `pp.tagAppFns` mode,
generalized field notation is tagged with the head constant. The effect
is that docgen documentation will linkify dot notation. Internal change:
now formatted `rawIdent` can be tagged.
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 25, 2025
…r#6703)

This PR modifies the delaborator so that in `pp.tagAppFns` mode,
generalized field notation is tagged with the head constant. The effect
is that docgen documentation will linkify dot notation. Internal change:
now formatted `rawIdent` can be tagged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-pp Pretty printing toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants