Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow updating binders to and from strict- and instance-implicit #6634

Merged
merged 4 commits into from
Feb 5, 2025
Merged

feat: allow updating binders to and from strict- and instance-implicit #6634

merged 4 commits into from
Feb 5, 2025

Conversation

jrr6
Copy link
Contributor

@jrr6 jrr6 commented Jan 14, 2025 •
edited
Loading

This PR adds support for changing the binder annotations of existing variables to and from strict-implicit and instance-implicit using the variable command.

This PR requires a stage0 update to fully take effect.

Closes #6078

@jrr6 jrr6 added the changelog-language Language features, tactics, and metaprograms label Jan 14, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 14, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 14, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 734fca7b6a126f4633ee065a3e263b1c5eee7b01 --onto d2c4471cfa4611977bf4927b5cd849df1a4272b7. (2025-01-14 01:06:17)
  • ✅ Mathlib branch lean-pr-testing-6634 has successfully built against this PR. (2025-01-14 02:14:12) View Log
  • 🟡 Mathlib branch lean-pr-testing-6634 build against this PR was cancelled. (2025-01-14 15:22:05) View Log
  • ✅ Mathlib branch lean-pr-testing-6634 has successfully built against this PR. (2025-01-14 16:04:20) View Log
  • ✅ Mathlib branch lean-pr-testing-6634 has successfully built against this PR. (2025-01-16 19:57:33) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 897e9c5388a139ac24069da6e6978ee60f914039 --onto 412389f71f8a24307e3adba69b38b4b685b04f72. (2025-02-04 20:43:36)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f1ed830b9a2e3614600fb8dcf8ab394b6e87e1c5 --onto 412389f71f8a24307e3adba69b38b4b685b04f72. (2025-02-05 15:34:42)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6634
01bdd51
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6634
5b47bd0
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 14, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 14, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6634
e1060c8
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 14, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6634
540ee9b
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 14, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6634
26364a5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 14, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6634
72dacc4
@jrr6 jrr6 marked this pull request as ready for review January 16, 2025 01:49
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 16, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6634
c2a1b18
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 16, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6634
bc7e464
@kim-em kim-em requested a review from kmill February 3, 2025 07:16
@jrr6 jrr6 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into leanprover:master with commit 60aeb79 Feb 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill approved these changes

@kim-em kim-em kim-em approved these changes

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binder can't update to typeclass argument
4 participants
@jrr6 @leanprover-community-bot @kmill @kim-em