feat: termBeforeBy builtin parser
#11495
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
changelog-no |
github-actions
bot
added
the
changelog-no
Rob23oba
reviewed
Dec 3, 2025
| disallows `by` outside of a bracketing construct. This is used for parsers like `show p by ...` | ||
| or `suffices p by ...`, where we do not want `p by ...` to be parsed as an application of `p` to a | ||
| `by` block, which would otherwise be allowed. -/ | ||
| def termBeforeBy := withForbidden "by" termParser |
Contributor
There was a problem hiding this comment.
Right, since this is not used anywhere yet, you'll have to tag it with @[run_builtin_parser_attribute_hooks] to make the alias work.
Contributor
Author
There was a problem hiding this comment.
We do need to use it in this file, but I had originally left this for the follow-up PR. I've now added the two uses in this PR.
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines the
termBeforeByparser which we will need in order to increase the precedence of thebyterm parser.