Skip to content

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Nov 18, 2025

This PR renames String.ValidPos to String.Pos, String.endValidPos to String.endPos and String.startValidPos to String.startPos.

Accordingly, the deprecations of String.Pos to String.Pos.Raw and String.endPos to String.rawEndPos are removed early, after an abbreviated deprecation cycle of two releases.

@TwoFX TwoFX added the changelog-library Library label Nov 18, 2025
@TwoFX TwoFX marked this pull request as draft November 18, 2025 12:05
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 18, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 18, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4296f8deeece4fdf6dbe7d5d6b5e23bd6a250d13 --onto 5a4226f2bdcc6299df76285b1d30f238546c09fe. You can force Mathlib CI using the force-mathlib-ci label. (2025-11-18 13:08:23)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9fc90488ce239cfe8e4317269d37fe4160787d0d --onto 5a4226f2bdcc6299df76285b1d30f238546c09fe. You can force Mathlib CI using the force-mathlib-ci label. (2025-11-19 10:36:20)
  • 💥 Mathlib branch lean-pr-testing-11240 build failed against this PR. (2025-11-24 15:40:55) View Log
  • ✅ Mathlib branch lean-pr-testing-11240 has successfully built against this PR. (2025-11-24 18:18:54) View Log

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Nov 18, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 4296f8deeece4fdf6dbe7d5d6b5e23bd6a250d13 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-11-18 13:08:24)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 9fc90488ce239cfe8e4317269d37fe4160787d0d --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-11-19 10:36:22)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-11-24 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-11-24 15:36:03)

github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2025
This PR is a preparatory bootstrapping PR for #11240.
@TwoFX TwoFX force-pushed the markus/validpostopos branch from 98ae1ab to 7192add Compare November 19, 2025 09:39
@TwoFX TwoFX force-pushed the markus/validpostopos branch from 7192add to 928f445 Compare November 24, 2025 14:28
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 24, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Nov 24, 2025
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Nov 24, 2025
@TwoFX TwoFX marked this pull request as ready for review November 24, 2025 16:40
@TwoFX TwoFX enabled auto-merge November 24, 2025 16:40
@TwoFX TwoFX added this pull request to the merge queue Nov 24, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 24, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Nov 24, 2025
Merged via the queue into leanprover:master with commit fa67f30 Nov 24, 2025
18 checks passed
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants