feat: implement in and is operators #508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation for in on tuples and lists, and is for the spacial case of None.
govereau
requested review from
jiancheng-aws,
joonwonc,
jtristan,
ppotapov-aws,
seanmcl,
waahm7 and
yongweiy
as code owners
waahm7
reviewed
Nov 26, 2025
| | .boolOp op l => return (<- booleanOp op (<- exprs l)).expr | ||
| | .binOp op l r => return .binOp (<- binOp op) (<- expr l) (<- expr r) | ||
| | .unaryOp op e => return (<- unaryOp op) (<- expr e) | ||
| | .compare a [.is] [⟨.const .none, pos⟩] => |
Collaborator
There was a problem hiding this comment.
I thought we were not going to support is in our language because it's not equivalent to ==
waahm7
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for in on tuples and lists, and is for the spacial case of None.