Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tactic steps now include used constants #59

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

adamtopaz
Copy link
Contributor

When the repl responds with a tactic step, the response will now include an array with the names of the constants used in the step.

Implementation details: Given a tactic info i : TacticInfo, we calculate the used constants as follows:

  • Look at the mvarid's in i.goalsBefore, and focus on those which have been assigned in i.mctxAfter.
  • Look at each such assignment, and collect the used constants as a NameSet.
  • Take the union of all these NameSets, and convert the result to an array.

In the future it would be better to give the user an option of whether or not to include the used constants, but having a more robust configuration system for the whole package would probably be the way to go.

@kim-em kim-em merged commit 65f1337 into leanprover-community:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants