fix: keep track of pexpr data #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a non-fully-qualified name occurred directly as one of: * the entire body of a definition/theorem * an argument to notation (e.g., `a` in `a + 1`) mathport did not keep track of the pexpr containing the fully-qualified name, and as a result, would not in general translate it to the aligned Lean 4 version. Fix this by passing along the pexpr data.
|
Does this fix #167? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a non-fully-qualified name occurred directly as one of:
aina + 1)mathport did not keep track of the pexpr containing the fully-qualified name, and as a result, would not in general translate it to the aligned Lean 4 version. Fix this by passing along the pexpr data.