chore: bump the version of leanprover-community/quote4 #9401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
easy
eric-wieser
commented
Jan 2, 2024
lake-manifest.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| {"url": "https://github.com/leanprover-community/quote4", | |||
| "type": "git", | |||
| "subDir": null, | |||
| "rev": "ccba5d35d07a448fab14c0e391c8105df6e2564c", | |||
There was a problem hiding this comment.
|
!bench |
|
Here are the benchmark results for commit 57efa46. Benchmark Metric Change
=========================================================
- ~Mathlib.Tactic.CancelDenoms.Core instructions 87.4% |
|
That's a little worrying, but probably not a disaster. #9421 makes some small cleanups to that file that may or may not be relevant. |
|
!bench |
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
|
This PR/issue depends on:
|
|
Here are the benchmark results for commit 345f351. Benchmark Metric Change
==============================================================
- ~Mathlib.Analysis.NormedSpace.Spectrum instructions 12.7%
- ~Mathlib.Tactic.CancelDenoms.Core instructions 140.3% |
|
Closing, this ended up merged as part of #9424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in leanprover-community/quote4#31, which is mainly just cleanup until leanprover/lean4#3060 lands in core too.
0fd24ec contains a test of the core PR + this change.