Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Naturality of integral curves #9341

Open
wants to merge 137 commits into
base: master
Choose a base branch
from

Conversation

winstonyin
Copy link
Collaborator

@winstonyin winstonyin commented Dec 29, 2023

Let v and v' be sections of the tangent bundle of manifolds M and M', respectively, and let f : M → M' be a differentiable map. Then f maps integral curves of v to integral curves of v' if and only if v and v' are f-related.


Open in Gitpod

winstonyin and others added 30 commits November 13, 2023 15:00
- use lowerCamelCase for our definitions, per the naming convention.
- sketch how to prove a few more sorries.
all results in this file hold for topological manifolds.
…ion.

The current lemma (frontier of (e.extend I).target) has contributions
from boundary(I.range) (good), but also from another factor (bad).
we should ask for x not being an interior of its chart's target.
(Asking for "lies in the frontier", as we did before, would also include
boundary points of (extChartAt I x).source in interior (range I),
which we're not interested in.)
In other words, the previous definition was actually *wrong*.
- make some variables explicit; fix namespacing of one result.
- move all topology helper results into their own section.
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 29, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 5, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 5, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a preliminary look: looks pretty good to me. I would define f-relatedness, a new minor comments and then, once the dependent PR has been merged, it's good to go from my side.

If you want: add the Lie bracket under f-relatedness as a future TODO.


/-- Let `v` and `v'` be vector fields on `M` and `M'`, respectively, and let `f : M → M'` be a
differentiable map. If `v` and `v'` are `f`-related, then `f` maps integral curves of `v` to
integral curves of `v'`. The converse is stated below. -/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is scope creep, but... how about introducing a definition of f-related vector fields? (I don't mind any somewhat interesting API being out of scope, but the definition would be useful, I think.)

∃ (γ : ℝ → M), γ t₀ = x₀ ∧ IsIntegralCurveAt γ v t₀ :=
exists_isIntegralCurveAt_of_contMDiffAt t₀ hv (BoundarylessManifold.isInteriorPoint I)

section Naturality
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a doc-string to this section, and - more importantly, mention this result in the high-level docstring?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course! If we're going to introduce f-relatedness and so on, which will be in a different file, this section should probably also go in a different file.

@grunweg
Copy link
Collaborator

grunweg commented Jan 8, 2024

I just realised: defining f-relatedness might entail defining vector fields as well. Sorry. I think this would be a great addition as well.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jan 9, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 9, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 9, 2024
@winstonyin
Copy link
Collaborator Author

I agree with the need for new definitions. There's already ContMDiffSection, which we can perhaps generalise. I'll think about this another day.

@grunweg grunweg added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jan 9, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 23, 2024
Copy link

github-actions bot commented Aug 27, 2024

PR summary 1355af371a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsIntegralCurveAt.of_mdifferentiable_related
+ comp_smulRight
+ mdifferentiable_related_of_isIntegralCurveAt

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 30, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-differential-geometry Manifolds etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants