Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Algebra/Order/GroupWithZero/Unbundled): deprecate useless lemmas, use ZeroLEOneClass #9250

Closed
wants to merge 27 commits into from

Conversation

FR-vdash-bot
Copy link
Collaborator

@FR-vdash-bot FR-vdash-bot commented Dec 23, 2023

There are still some useless lemmas that were simply ported from Algebra.Order.Monoid.Lemmas, such as just chain an existing lemma with an assumption and lemmas whose assumptions imply 1 ≤ 0. This PR removes them.

Also, some lemmas have both assumptions like 1 < a 0 < a. This PR uses ZeroLEOneClass to remove redundant assumptions.


Ported from leanprover-community/mathlib3#16525 and leanprover-community/mathlib3#18158

Open in Gitpod

@FR-vdash-bot FR-vdash-bot added WIP Work in progress awaiting-review awaiting-CI t-algebra Algebra (groups, rings, fields, etc) t-order Order theory labels Dec 23, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 16, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 22, 2024
@FR-vdash-bot FR-vdash-bot changed the title chore(Algebra/Order/Lemmas): remove useless lemmas, use ZeroLEOneClass chore(Algebra/Order/GroupWithZero/Unbundled): remove useless lemmas, use ZeroLEOneClass May 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 23, 2024
@urkud
Copy link
Member

urkud commented May 26, 2024

Could you please deprecate them instead?

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 8, 2024
Copy link

github-actions bot commented Jul 13, 2024

PR summary 09a72c1f57

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Left.one_le_mul₀
+ Left.one_lt_mul_of_le_of_lt₀
+ Left.one_lt_mul_of_lt_of_le₀
+ Left.one_lt_mul₀
+ Left.zero_lt_one_of_pos
+ Right.one_le_mul₀
+ Right.one_lt_mul_of_le_of_lt₀
+ Right.one_lt_mul_of_lt_of_le₀
+ Right.one_lt_mul₀
+ Right.zero_lt_one_of_pos
+ mul_le_one
+ mul_le_one_left
+ mul_le_one_right
+ mul_lt_one_left
+ mul_lt_one_of_le_of_lt_left
+ mul_lt_one_of_le_of_lt_right
+ mul_lt_one_of_lt_of_le_left
+ mul_lt_one_of_lt_of_le_right
+ mul_lt_one_right
+ one_le_mul_of_le_of_le
+ one_lt_mul_of_lt_of_lt
+ zero_lt_one_of_pos

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@FR-vdash-bot FR-vdash-bot added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 13, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 16, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 17, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 24, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 31, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 3, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 17, 2024
@FR-vdash-bot FR-vdash-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 28, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 7, 2024
@FR-vdash-bot FR-vdash-bot changed the title chore(Algebra/Order/GroupWithZero/Unbundled): remove useless lemmas, use ZeroLEOneClass chore(Algebra/Order/GroupWithZero/Unbundled): deprecate useless lemmas, use ZeroLEOneClass Oct 9, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc) t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants