Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(RingTheory/Congruence): add the CompleteLattice instance #8313

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(RingTheory/Congruence): add the CompleteLattice instance #8313

wants to merge 9 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 10, 2023 •
edited
Loading

The code is copied from GroupTheory/Congruence.lean, and then modified to fix the errors.

I haven't copied the full contents of GroupTheory/Congruencee, only the results about the lattice structure.

This replaces leanprover-community/mathlib3#18588

Open in Gitpod

YaelDillies
YaelDillies reviewed Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason you did not act on my comments on leanprover-community/mathlib3#18588 ? Would you mind doing so?

@eric-wieser
Copy link
Member Author

Primarily because they requested cleanup that seemed out of scope (which is what the other PR i made is for). I'm happy to make this one depend on that one.

@YaelDillies
Copy link
Collaborator

I'm happy for the cleanups to happen later if you pinky-promise to actually do them.

YaelDillies
YaelDillies reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status wrt to the unresolved comments on the mathlib3 PR?

Mathlib/RingTheory/Congruence.lean Outdated Show resolved Hide resolved
@eric-wieser
Copy link
Member Author

What's the status wrt to the unresolved comments on the mathlib3 PR?

I now intend to address them, but have not checked that I have done so.

@YaelDillies YaelDillies added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 27, 2023
@eric-wieser
Copy link
Member Author

What's the status wrt to the unresolved comments on the mathlib3 PR?

I've resolved all the comments there that are addressed here. I don't think your distrib suggestions are obviously true, and would rather not take on proving new mathematical results as part of this PR.

@eric-wieser eric-wieser added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 4, 2023
YaelDillies
YaelDillies approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 12, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 12, 2023
@eric-wieser
feat(RingTheory/Congruence): add the CompleteLattice instance (#8313)
28f7b0b 
The code is copied from `GroupTheory/Congruence.lean`, and then modified to fix the errors.

I haven't copied the full contents of `GroupTheory/Congruencee`, only the results about the lattice structure.

This replaces leanprover-community/mathlib3#18588
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 12, 2023

Build failed:

@eric-wieser
Copy link
Member Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 16, 2023
@eric-wieser
feat(RingTheory/Congruence): add the CompleteLattice instance (#8313)
eb4573a 
The code is copied from `GroupTheory/Congruence.lean`, and then modified to fix the errors.

I haven't copied the full contents of `GroupTheory/Congruencee`, only the results about the lattice structure.

This replaces leanprover-community/mathlib3#18588
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 16, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Congruence): add the CompleteLattice instance [Merged by Bors] - feat(RingTheory/Congruence): add the CompleteLattice instance Dec 16, 2023
@mathlib-bors mathlib-bors bot closed this Dec 16, 2023
@mathlib-bors mathlib-bors bot deleted the RingCon-lattice branch December 16, 2023 02:09
awueth pushed a commit that referenced this pull request Dec 19, 2023
@eric-wieser @awueth
feat(RingTheory/Congruence): add the CompleteLattice instance (#8313)
ce31973 
The code is copied from `GroupTheory/Congruence.lean`, and then modified to fix the errors.

I haven't copied the full contents of `GroupTheory/Congruencee`, only the results about the lattice structure.

This replaces leanprover-community/mathlib3#18588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-wieser @YaelDillies @riccardobrasca