[Merged by Bors] - fix(Tactic/Polyrith): fix crash when hypotheses are constant polynomials #7586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
t-meta
eric-wieser
changed the title
|
I think we will have to revisit the design a bit in future (as we discussed in https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.237586.20.2F.20!3.2317142.3A.20polyrith.20crash/near/397199367) but this seems to enable at least a couple of examples to work that didn't previously so looks good to me. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alexjbest. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
…als (#7586) This forward-ports leanprover-community/mathlib3#17142 The tests are commented out because the test framework for polyrith was never ported. You can check out the branch and run polyrith manually to see that everything is ok.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forward-ports leanprover-community/mathlib3#17142
The tests are commented out because the test framework for polyrith was never ported. You can check out the branch and run polyrith manually to see that everything is ok.
Note the mathlib3 PR has not yet been merged.