[Merged by Bors] - feat: explicit volume computations in NumberTheory.NumberField.CanonicalEmbedding #6886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xroblot
force-pushed
the
xfr_volume-computations
branch
from
57e9d20 to
a254aac
Compare
xroblot
added
WIP
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
leanprover-community-mathlib4-bot
added
the
merge-conflict
… xfr-complex_ball
jcommelin
reviewed
Nov 3, 2023
jcommelin
reviewed
Nov 3, 2023
jcommelin
approved these changes
Nov 3, 2023
|
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 4, 2023
…calEmbedding (#6886) We compute the values of the volumes used in `CanonicalEmbedding`. In particular, we prove that ```lean volume (fundamentalDomain (latticeBasis K)) = (2 : ℝ≥0∞)⁻¹ ^ (NrComplexPlaces K) * NNReal.sqrt ‖discr K‖₊ ``` This will be useful later on to prove Hermite and Hermite-Minkowski theorems.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We compute the values of the volumes used in
CanonicalEmbedding. In particular, we prove thatvolume (fundamentalDomain (latticeBasis K)) = (2 : ℝ≥0∞)⁻¹ ^ (NrComplexPlaces K) * NNReal.sqrt ‖discr K‖₊This will be useful later on to prove Hermite and Hermite-Minkowski theorems.