Skip to content

[Merged by Bors] - chore(Algebra/Group/Pointwise/{Fin}set/Basic): split files #23429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

BoltonBailey
Copy link
Collaborator

@BoltonBailey BoltonBailey commented Mar 29, 2025

This PR splits the files on pointwise operations on sets, creating new files for the scalar multiplication etc. operations.

This addresses an instance of the long file linter, while keeping the directory structure analogous.


Open in Gitpod

Copy link

github-actions bot commented Mar 29, 2025

PR summary 484ff183d1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
There are 3042 files with changed transitive imports taking up over 136350 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.07)
Current number Change Type
14 -1 large files

Current commit 484ff183d1
Reference commit 44dc3a3a60

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@BoltonBailey BoltonBailey added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Mar 29, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 29, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 29, 2025
@kim-em
Copy link
Contributor

kim-em commented Mar 30, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Mar 30, 2025
mathlib-bors bot pushed a commit that referenced this pull request Mar 30, 2025
This PR splits the files on pointwise operations on sets, creating new files for the scalar multiplication etc. operations.

This addresses an instance of the long file linter, while keeping the directory structure analogous.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 31, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Group/Pointwise/{Fin}set/Basic): split files [Merged by Bors] - chore(Algebra/Group/Pointwise/{Fin}set/Basic): split files Mar 31, 2025
@mathlib-bors mathlib-bors bot closed this Mar 31, 2025
@mathlib-bors mathlib-bors bot deleted the BoltonBailey/split-scalar-pointwise branch March 31, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants