chore: review of porting notes in Analysis/ #22773
Open
+81
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kim-em
commented
Mar 10, 2025
kim-em
commented
PR summary bae025ab45Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (7.86, 0.09)
Current commit bae025ab45 You can run this locally as
|
leanprover-community-bot-assistant
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
Ruben-VandeVelde
approved these changes
Mar 11, 2025
| @@ -73,7 +73,6 @@ scoped[MultiplierAlgebra] notation "𝓜(" 𝕜 ", " A ")" => DoubleCentralizer | |||
|
|
|||
| open MultiplierAlgebra | |||
|
|
|||
| -- Porting note: `ext` was generating the wrong extensionality lemma; it deconstructed the `×`. | |||
There was a problem hiding this comment.
ext doesn't happen to have gotten smarter yet?
There was a problem hiding this comment.
No. I think we long ago decided that the new ext behaviour is better. Library authors need to add additional @[ext] lemmas if there are situations where the new ext will not break open definitions that the old ext was willing to. (The old ext just blindly calls apply with every ext lemma. The new ext uses a discrimination tree.)
Comment on lines
257
to
261
| AffineMap.mk' f (↑((AddMonoidHom.ofMapMidpoint ℝ ℝ | ||
| ((AffineEquiv.vaddConst ℝ (f <| c)).symm ∘ f ∘ AffineEquiv.vaddConst ℝ c) (by simp) | ||
| fun x y => by -- Porting note: was `by simp [h]` | ||
| simp only [c, Function.comp_apply, AffineEquiv.vaddConst_apply, | ||
| AffineEquiv.vaddConst_symm_apply] | ||
| conv_lhs => rw [(midpoint_self ℝ (Classical.arbitrary P)).symm, midpoint_vadd_midpoint, h, h, | ||
| midpoint_vsub_midpoint]).toRealLinearMap <| by | ||
| fun x y => by simp [h]).toRealLinearMap <| by | ||
| apply_rules [Continuous.vadd, Continuous.vsub, continuous_const, hfc.comp, continuous_id])) | ||
| c fun p => by simp |
There was a problem hiding this comment.
(Wow, this is unreadable)
b-mehta
approved these changes
Mar 11, 2025
Co-authored-by: Ruben Van de Velde <[email protected]>
…ity/mathlib4 into porting_notes_analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.