-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scripts to test if there are keys in references.bib with non-ASCII characters #22757
base: master
Are you sure you want to change the base?
Conversation
PR summary bed8be186bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like somebody else to double-check.
Co-authored-by: grunweg <[email protected]>
It's best if the script can output a diff with non-ASCII characters in key replaced by corresponding ASCII characters. But I haven't figured out how to do it using bibtool. From bibtool documentation seems that there is a macro |
Currently doc-gen4 does not support non-ASCII characters as reference keys in reference.bib. What's worse, it will stops processing that file silently. This leads to various mathlib4 docs reference page errors.
This PR adds scripts to test if there are keys in references.bib with non-ASCII characters. A demonstration is at https://github.com/leanprover-community/mathlib4/actions/runs/13759366997/job/38472088509.