Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: density of a union of finsets #22629

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: density of a union of finsets #22629

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

From PlainCombi (LeanCamCombi)


Open in Gitpod

From PlainCombi (LeanCamCombi)
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

PR summary eff25e81ec

Import changes exceeding 2%

% File
+18.26% Mathlib.Algebra.BigOperators.Field

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.BigOperators.Field 586 693 +107 (+18.26%)
Import changes for all files
Files Import difference
Mathlib.Combinatorics.SetFamily.LYM 15
Mathlib.Algebra.BigOperators.Field 107

Declarations diff

+ dens_biUnion
+ dens_biUnion_le
+ dens_disjiUnion
+ dens_eq_sum_dens_fiberwise
+ dens_eq_sum_dens_image

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 6, 2025
@b-mehta
Copy link
Contributor

b-mehta commented Mar 8, 2025

Looks great! I'm content with the large-import since there's a clear (and documented) plan to resolve it in the future. Thank you!

@b-mehta b-mehta added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. large-import Automatically added label for PRs with a significant increase in transitive imports t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants