-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RingTheory/DividedPowers/DPMorphism): add divided power morphisms #22318
base: master
Are you sure you want to change the base?
Conversation
PR summary c9edd9284eImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain how one is supposed to introduce a divided power morphism? Using IsDPMorphism
or the bundled version?
Thanks!
bors d+
`A → B` is a divided power morphism if it is compatible with these divided power structures. -/ | ||
def IsDPMorphism {A B : Type*} [CommSemiring A] [CommSemiring B] {I : Ideal A} {J : Ideal B} | ||
(hI : DividedPowers I) (hJ : DividedPowers J) (f : A →+* B) : Prop := | ||
I.map f ≤ J ∧ ∀ {n : ℕ}, ∀ a ∈ I, hJ.dpow n (f a) = f (hI.dpow n a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making this into a structure with two fields? It seems more natural (and mathematically it is exactly the same).
✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with |
Let
A
andB
be commutative (semi)rings, letI
be an ideal ofA
and letJ
be an ideal ofB
. Given divided power structures onI
andJ
, a ring morphismA →+* B
is a dividedpower morphism if it is compatible with these divided power structures.
Co-authored-by: AntoineChambert-Loir [email protected]