-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CategoryTheory/DiscreteCategory): binary sums and products of discrete categories #22281
base: master
Are you sure you want to change the base?
Conversation
…screte categories
PR summary 65ee99958fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, LGTM!
I also like the DiscreteCategory
folder, but what about naming it just Discrete
so its shorter? CategoryTheory.Discrete
should still be an unambiguous import.
|
We show that if
C
andD
are discrete categories, thenC ⊕ D
andC × D
are also discrete categories. This is stated both in terms of equivalencesDiscrete (J × K) ≌ Discrete J × Discrete K
andDiscrete (J ⊕ K) ≌ Discrete J ⊕ Discrete K
, and in terms of theIsDiscrete
typeclass.We also implement a small refactor by creating a directory
CategoryTheory/DiscreteCategory
and movingCategoryTheory/DiscreteCategory.lean
toCategoryTheory/DiscreteCategory/Basic.lean
.I opted for the creation of a separate directory about
DiscreteCategory
so that one could still importDiscreteCategory.Basic
but not necessarily the content of this PR, which importsCategoryTheory.Sums.Basic
andCategoryTheory.Products.Basic
.