Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Combinatorics/SimpleGraph): define odd components #22125

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pimotte
Copy link
Collaborator

@pimotte pimotte commented Feb 20, 2025

Adds the definition oddComponents: The set of connected components of odd cardinality.
In preparation for Tutte's theorem.


Open in Gitpod

Zulip thread on Tutte's

@pimotte pimotte added the t-combinatorics Combinatorics label Feb 20, 2025
@pimotte pimotte requested a review from YaelDillies February 20, 2025 13:43
Copy link

github-actions bot commented Feb 20, 2025

PR summary 9ad99587a3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ConnectedComponent.odd_oddComponents_ncard_subset_supp
+ ncard_oddComponents_mono
+ oddComponents
+ odd_ncard_oddComponents
- ConnectedComponent.odd_card_supp_iff_odd_subcomponents
- ncard_odd_components_mono
- odd_card_iff_odd_components

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants