Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Order/Nucleus): coe_mk simp lemma #21346

Closed
wants to merge 3 commits into from

Conversation

Bergschaf
Copy link
Collaborator

@Bergschaf Bergschaf commented Feb 2, 2025

Add Nucleus.coe_mk.


FrameHom, etc. have the analogous lemma already

Open in Gitpod

Copy link

github-actions bot commented Feb 2, 2025

PR summary 4a1ecc034b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_mk

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Bergschaf Bergschaf added easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory labels Feb 2, 2025
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

Mathlib/Order/Nucleus.lean Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 3, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 3, 2025

✌️ Bergschaf can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Bergschaf
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 3, 2025
Add `Nucleus.coe_mk`.
 


Co-authored-by: Bergschaf <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 3, 2025

Build failed:

@Bergschaf
Copy link
Collaborator Author

Bergschaf commented Feb 3, 2025

It seems like @[norm_cast] can only be used when the right hand side is not a coercion. But this is not the case for the Nucleus, because f is an InfHom and not a Function. (Ok, i saw your post above)

mathlib-bors bot pushed a commit that referenced this pull request Feb 3, 2025
Add `Nucleus.coe_mk`.
 


Co-authored-by: Bergschaf <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 3, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order/Nucleus): coe_mk simp lemma [Merged by Bors] - feat(Order/Nucleus): coe_mk simp lemma Feb 3, 2025
@mathlib-bors mathlib-bors bot closed this Feb 3, 2025
@mathlib-bors mathlib-bors bot deleted the Nucleus_coe_mk branch February 3, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants