Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attempt to avoid diamond in OreLocalization #21344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Feb 2, 2025


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 2, 2025
Copy link

github-actions bot commented Feb 2, 2025

PR summary 5c2599380c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kbuzzard
Copy link
Member Author

kbuzzard commented Feb 2, 2025

The example which inspired this (Zulip) still doesn't work:

import Mathlib

example :
    -- comes from `OreLocalization.hsmul`, depends on `SMul ℤ ℤ`
    @instHSMul ℤ (Localization (Submonoid.powers (2 : ℤ))) OreLocalization.instSMulOfIsScalarTower =
    -- comes from `OreLocalization.zsmul`, depends on `AddGroup ℤ`
    @instHSMul ℤ (Localization.Away (2 : ℤ)) SubNegMonoid.toZSMul := by
  unfold instHSMul SMul.smul SubNegMonoid.toZSMul SubNegMonoid.zsmul
  unfold OreLocalization.instSMulOfIsScalarTower
  unfold AddGroup.toSubNegMonoid OreLocalization.instAddGroupOreLocalization
  dsimp only
  unfold OreLocalization.zsmul
  rfl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant