Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FieldTheory): split Mathlib.FieldTheory.Purelyinseparable #21343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mistarro
Copy link
Collaborator

@mistarro mistarro commented Feb 2, 2025


Open in Gitpod

Copy link

github-actions bot commented Feb 2, 2025

PR summary b83de8e32a

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.FieldTheory.PurelyInseparable 1534 0 -1534 (-100.00%)
Mathlib.FieldTheory.CardinalEmb 1537 1535 -2 (-0.13%)
Mathlib.FieldTheory.JacobsonNoether 1560 1558 -2 (-0.13%)
Mathlib.RingTheory.Unramified.Field 1951 1949 -2 (-0.10%)
Mathlib.FieldTheory.IsPerfectClosure 1536 1535 -1 (-0.07%)
Import changes for all files
Files Import difference
Mathlib.FieldTheory.PurelyInseparable -1534
4 files Mathlib.FieldTheory.CardinalEmb Mathlib.FieldTheory.JacobsonNoether Mathlib.RingTheory.Etale.Field Mathlib.RingTheory.Unramified.Field
-2
Mathlib.FieldTheory.IsPerfectClosure -1
Mathlib.FieldTheory.PurelyInseparable.Basic (new file) 1532
Mathlib.FieldTheory.PurelyInseparable.RelPerfectClosure (new file) 1535
Mathlib.FieldTheory.PurelyInseparable.Tower (new file) 1536

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 2, 2025
@mistarro mistarro requested a review from acmepjz February 2, 2025 12:15
Copy link
Collaborator

@acmepjz acmepjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Looks good to me. I haven't spot any mistakes.

@acmepjz acmepjz requested a review from alreadydone February 2, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants