Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(InfiniteSum/NatInt): put Multipliable.tendsto_prod_tprod_nat in the right namespace #21337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pechersky
Copy link
Collaborator

Before, it was:

HasProd.Multipliable.tendsto_prod_tprod_nat

which made the additive version

HasSum.Multipliable.tendsto_prod_tprod_nat

By lifting into the root namespace, Multipliable properly additivizes


Open in Gitpod

…in the right namespace

Before, it was:
```
HasProd.Multipliable.tendsto_prod_tprod_nat
```
which made the additive version
```
HasSum.Multipliable.tendsto_prod_tprod_nat
```

By lifting into the root namespace, Multipliable properly additivizes
@pechersky pechersky added the easy < 20s of review time. See the lifecycle page for guidelines. label Feb 2, 2025
Copy link

github-actions bot commented Feb 2, 2025

PR summary 5df6d24ea8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ HasProd.tendsto_prod_nat
- tendsto_prod_nat

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant