Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SMul with Top #21316

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: SMul with Top #21316

wants to merge 2 commits into from

Conversation

ScottCarnahan
Copy link
Collaborator

@ScottCarnahan ScottCarnahan commented Feb 1, 2025

This PR introduces a type alias SMulTop for WithTop and adds a SMul (WithTop G) (SMulTop P) instance given SMul G P. There is a corresponding instance for IsOrderedSMul, and additive versions of both.


Open in Gitpod

@ScottCarnahan ScottCarnahan added WIP Work in progress t-order Order theory labels Feb 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

PR summary cae0f300ed

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Order.SMulWithTop (new file) 224

Declarations diff

+ SMulTop
+ SMulTop.coe_SMul
+ SMulTop.coe_ne_smultop
+ SMulTop.coe_smul_eq_top_iff
+ SMulTop.le_iff
+ SMulTop.le_top
+ SMulTop.lt_iff
+ SMulTop.lt_top_iff_ne_top
+ SMulTop.of
+ SMulTop.of_symm_top
+ SMulTop.of_top
+ SMulTop.rec
+ SMulTop.smul_coe_eq_top_iff
+ SMulTop.smul_eq_top
+ SMulTop.smul_lt_top
+ SMulTop.smul_ne_top
+ SMulTop.smul_top
+ SMulTop.smultop_ne_coe
+ SMulTop.top_SMul
+ SMulTop.top_le_iff
+ given
+ instance (priority := 10) [LE P] : LE (SMulTop P)
+ instance (priority := 10) [LT P] : LT (SMulTop P)
+ instance : Top (SMulTop P)
+ instance [LE G] [LE P] [IsOrderedSMul G P] :
+ instance [SMul G P] : SMul (WithTop G) (SMulTop P)

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant