-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CategoryTheory/SmallObject): generalization of the definitions #20256
Open
joelriou
wants to merge
83
commits into
master
Choose a base branch
from
small-object-8-bis-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+666
−575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iterations of functors in two cases
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Junyan Xu <[email protected]>
…ape.lean Co-authored-by: Markus Himmel <[email protected]>
…l-object-8-bis-refactor
github-actions
bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jan 24, 2025
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Jan 24, 2025
… small-object-8-bis-refactor
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Jan 26, 2025
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Feb 2, 2025
mathlib4-dependent-issues-bot
added
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
and removed
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
labels
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
large-import
Automatically added label for PRs with a significant increase in transitive imports
t-category-theory
Category theory
WIP
Work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ongoing definition of the iteration of a natural transformation
ε : 𝟭 C ⟶ F
(withF : C ⥤ C
) is generalized to "successor structures" (which shall become a mathlibism), i.e. in a categoryD
, this consists of a zeroth objectX₀
, a successor applicationsucc : D → D
and a maptoSucc X : X → succ X
(which does not have to be natural: it is not always so in some applications). For such aΦ : SuccStruct D
, ifJ
is a well-ordered type, we define theJ
-th iteration ofΦ
. (In the caseJ := ℕ
, this is the colimit ofsucc (succ (succ (succ ... X₀)))
.)The iteration of a functor is a particular case of this constructor with
D := C ⥤ C
.As
toSucc
does not have to be natural inX
, the caveat is that the proofs make extensive use of equalities of objects inC
andArrow C
, while my previous construction used comparison isomorphisms. Nevertheless, the proofs look much more clean now. One of the reasons is that in the inductive construction (fileIteration.Nonempty
), in the terms of data, we only need to provide a functor, and then all the fields are inProp
. (In the downstream API, we shall obviously use isomorphisms instead of equalities...)This PR supersedes #19264. The results are used in #20245 in order to get functorial factorizations in the small object argument.
After refactoring my code, I found that this approach had been already been used in 2018 by Reid Barton in his pioneering formalization work in Lean 3 towards the model category structure on topological spaces.