Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: norm_num for Int.ceil #19669

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 1, 2024

Long ago I tried writing this in leanprover-community/mathlib3#16502 for Lean 3.


Open in Gitpod

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Dec 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

PR summary a0f0cf4514

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ceil_def
+ ceil_intCast_div_natCast
+ ceil_natCast_div_natCast
+ evalIntCeil
+ isInt_intCeil
+ isInt_intCeil_ofIsRat
+ isNat_intCeil

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser force-pushed the eric-wieser/norm_num-Int.ceil branch from d6671db to a0f0cf4 Compare December 5, 2024 22:51
@eric-wieser eric-wieser marked this pull request as ready for review December 5, 2024 22:52
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak meta, but this seems to work.

maintainer merge?

Copy link

github-actions bot commented Dec 7, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@kim-em
Copy link
Contributor

kim-em commented Dec 10, 2024

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 10, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 10, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: norm_num for Int.ceil [Merged by Bors] - feat: norm_num for Int.ceil Dec 10, 2024
@mathlib-bors mathlib-bors bot closed this Dec 10, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/norm_num-Int.ceil branch December 10, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants