-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RingTheory/NoetherNormalization): Add Noether normalization lemma #18247
base: master
Are you sure you want to change the base?
Conversation
PR summary d818c2c745Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Ruben Van de Velde <[email protected]>
This PR/issue depends on: |
Can you please fix the conflict? Thanks! |
Mathlib/RingTheory/IntegralClosure/IsIntegralClosure/Basic.lean
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a short description of the strategy of the proof in the docstring at the beginning? It doesn't seem to be the same as in the stack project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few small comments
Co-authored-by: Riccardo Brasca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is really good and almost ready. In my opinion there are still two things to be done:
- you write a rather detailed proof strategy, but the description is before each theorem. I think it would be better to have it at the beginning of the file, with references to the actual declaration proving what you claim, maybe in a section "# Strategy of the proof" (for example you can say something like so that
T
maps
different monomials off
to mvpolynomials with different degrees ofX_0
, seename_of_the_theorem
). - we try to have descriptive names even for private lemmas. I know, this is annoying but it helps).
The best thing would be to try to extract some results, but I don't know if this is reasonable, they all seem very specific to this proof.
Co-authored-by: Michael Stoll <[email protected]>
This PR contains a proof of Noether normalization lemma:$r$ and an injective homomorphism from
Let
A
be a finitely generated algebra over a fieldk
. Then there exists natural numberk[X_1, X_2, ..., X_r]
toA
such thatA
is integral overk[X_1, X_2, ..., X_r]
.Co-authored-by: Riccardo Brasca [email protected]
Co-authored-by: Wan Lin [email protected]
Co-authored-by: Xiaoyang Su [email protected]