-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: norm_num ext for Int.floor
#13647
Conversation
PR summary ddb5680aa4Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Mathlib/Data/Rat/Floor.lean
Outdated
theorem isInt_intFloor {R} [LinearOrderedRing R] [FloorRing R] (r : R) (m : ℤ) : | ||
IsInt r m → IsInt ⌊r⌋ m := by rintro ⟨⟨⟩⟩; exact ⟨by simp⟩ | ||
|
||
theorem isInt_intFloor_ofIsRat [CharZero α] (r : α) (n : ℤ) (d : ℕ) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on Zulip, this CharZero
requirement comes for free once you import Algebra.Order.Ring.CharZero
. I really dislike for basic inheritance typeclasses to be hidden in obscure files, so I have opened #13654.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge master now that #13654 has landed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Marking as |
c56c329
to
ddb5680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
maintainer merge
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Thanks! bors merge The versions for ceiling and nat-floor/nat-ceil would also be great! |
I tried this a while ago in leanprover-community/mathlib3#16502; this is now just one of the handlers from that PR.
Pull request successfully merged into master. Build succeeded: |
Int.floor
Int.floor
I tried this a while ago in leanprover-community/mathlib3#16502; this is now just one of the handlers from that PR.
I tried this a while ago in leanprover-community/mathlib3#16502; this is now just one of the handlers from that PR.
I tried this a while ago in leanprover-community/mathlib3#16502; this is now just one of the handlers from that PR.
I tried this a while ago in leanprover-community/mathlib3#16502; this is now just one of the handlers from that PR.
Some questions:
NormNum/
directory?isFoo
lemmas supposed to be in theMathlib.Meta.NormNum
namespace?isNat
andisInt
handlers, sincesimp
can already deal with these?Do I really needCharZero
?