-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(Algebra/Lie/SkewAdjoint): from BilinForm to LinearMap.BilinForm #11078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
changed the title
refactor:(Algebra/Lie/SkewAdjoint): from BilinForm to LinearMap.BilinForm
refactor(Algebra/Lie/SkewAdjoint): from BilinForm to LinearMap.BilinForm
Mar 5, 2024
jcommelin
reviewed
Mar 5, 2024
@eric-wieser please do you have a moment to review this PR? I'm hoping it's fairly straight-forward. Thanks. |
eric-wieser
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Thanks!
leanprover-community-mathlib4-bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
labels
Mar 8, 2024
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
refactor(Algebra/Lie/SkewAdjoint): from BilinForm to LinearMap.BilinForm
[Merged by Bors] - refactor(Algebra/Lie/SkewAdjoint): from BilinForm to LinearMap.BilinForm
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
BilinForm
withLinearMap.BilinForm
in support of #10553