-
Notifications
You must be signed in to change notification settings - Fork 295
[Merged by Bors] - feat(algebra/module/zlattice): prove some results about Z-lattices #18266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how general we should make this file, clearly some of the bits at the end are quite specific to Z inside R, but results like zspan.mem_span_iff
seem useful more generally for quite arbitrary spans of subrings?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors d+
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
…18266) For a ℤ-lattice `L` given by `L := submodule.span ℤ (set.range b)` where `b` is a basis of finite dimensional real vector space `E`, this PR defines the fundamental domain of `L` and proves that it is a fundamental domain in the sense of `measure_theory.group.fundamental_domain`. It also introduces most of the tools that will be needed to prove that a discrete subgroup of `E` that spans `E` over `ℝ` is a ℤ-lattice, see #18477
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
For a ℤ-lattice
L
given byL := submodule.span ℤ (set.range b)
whereb
is a basis of finite dimensional real vector spaceE
, this PR defines the fundamental domain ofL
and proves that it is a fundamental domain in the sense ofmeasure_theory.group.fundamental_domain
.It also introduces most of the tools that will be needed to prove that a discrete subgroup of
E
that spansE
overℝ
is aℤ-lattice, see #18477