This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - split(algebra/order/nonneg): Separate ring and field instances
#17348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
11 tasks
eric-wieser
reviewed
Nov 4, 2022
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
…17348) Split `algebra.order.nonneg` into: * `algebra.order.nonneg.ring` for ring instances * `algebra.order.nonneg.field` for field and archimedean instances
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
…17348) Split `algebra.order.nonneg` into: * `algebra.order.nonneg.ring` for ring instances * `algebra.order.nonneg.field` for field and archimedean instances
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
…17348) Split `algebra.order.nonneg` into: * `algebra.order.nonneg.ring` for ring instances * `algebra.order.nonneg.field` for field and archimedean instances
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
…17348) Split `algebra.order.nonneg` into: * `algebra.order.nonneg.ring` for ring instances * `algebra.order.nonneg.field` for field and archimedean instances
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
…17348) Split `algebra.order.nonneg` into: * `algebra.order.nonneg.ring` for ring instances * `algebra.order.nonneg.field` for field and archimedean instances
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ring and field instancesring and field instances
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
algebra.order.nonneginto:algebra.order.nonneg.ringfor ring instancesalgebra.order.nonneg.fieldfor field and archimedean instancesAt this point in time, this is a no-op on the import tree, but I need this to introduce
nnrat.cast(see #16554).I also foresee that the field and archimedean instances will need further splitting, but I don't yet have evidence for this so I would rather leave this for later.