This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 295
chore(algebra/order/ring/lemmas): use suffix ₚ
, create aliases
#16523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iases The second part of #16449 This PR use the suffix "ₚ" on some theorems which assume positivity. Due to name conflicts, these similar lemmas have dissimilar names currently. If there is a better way to resolve name conflicts, please feel free to comment.
FR-vdash-bot
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
t-algebra
Algebra (groups, rings, fields etc)
t-order
Order hierarchy
labels
Sep 15, 2022
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Sep 15, 2022
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Sep 16, 2022
This PR/issue depends on: |
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Sep 16, 2022
FR-vdash-bot
changed the title
chore(algebra/order/monoid_lemmas_zero_lt): use suffix
chore(algebra/order/ring/lemmas): use suffix Nov 8, 2022
ₚ
, create aliasesₚ
, create aliases
Note that this file has now been ported to mathlib4, so will need a synchronization PR. |
kim-em
added
the
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
label
Nov 18, 2022
eric-wieser
added
the
not-too-late
This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4
label
Jul 15, 2023
This was forward-ported as leanprover-community/mathlib4#9249 (and ultimately abandoned there) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
awaiting-review
The author would like community review of the PR
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
not-too-late
This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4
t-algebra
Algebra (groups, rings, fields etc)
t-order
Order hierarchy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of #16449
This PR uses the suffix "ₚ" on some lemmas which assume positivity. Due to name conflicts, these similar lemmas have dissimilar names before this PR.
If there is a better way to resolve name conflicts, please feel free to comment.
mathlib4: leanprover-community/mathlib4#782
unify_with_instance
#16480