Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

chore(algebra/order/ring/lemmas): use suffix , create aliases #16523

Closed
wants to merge 11 commits into from

Conversation

FR-vdash-bot
Copy link
Collaborator

@FR-vdash-bot FR-vdash-bot commented Sep 15, 2022

The second part of #16449

This PR uses the suffix "ₚ" on some lemmas which assume positivity. Due to name conflicts, these similar lemmas have dissimilar names before this PR.

If there is a better way to resolve name conflicts, please feel free to comment.

mathlib4: leanprover-community/mathlib4#782


Open in Gitpod

…iases

The second part of #16449

This PR use the suffix "ₚ" on some theorems which assume positivity. Due to name conflicts, these similar lemmas have dissimilar names currently.

If there is a better way to resolve name conflicts, please feel free to comment.
@FR-vdash-bot FR-vdash-bot added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Sep 15, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 15, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 16, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 16, 2022
@FR-vdash-bot FR-vdash-bot changed the title chore(algebra/order/monoid_lemmas_zero_lt): use suffix , create aliases chore(algebra/order/ring/lemmas): use suffix , create aliases Nov 8, 2022
@kim-em
Copy link
Collaborator

kim-em commented Nov 18, 2022

Note that this file has now been ported to mathlib4, so will need a synchronization PR.

@kim-em kim-em added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Nov 18, 2022
@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
@eric-wieser
Copy link
Member

This was forward-ported as leanprover-community/mathlib4#9249 (and ultimately abandoned there)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants