Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

feat(category_theory/category/Pointed): Pointed is a monoidal category #15390

Closed
wants to merge 8 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jul 15, 2022

Provide the monoidal_category and symmetric_category instances for Pointed.


This is mostly an exercise for me to see whether I understand monoidal categories. Please suggest missing API. I tried to do the same for PartialFun over at branch PartialFun_monoidal but obviously timed out. Can I somehow use that PartialFun ≌ Pointed to transfer the monoidal structure? No, because that doesn't give the right monoidal structure.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Jul 15, 2022
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me!

src/category_theory/category/Pointed.lean Show resolved Hide resolved
@b-mehta
Copy link
Collaborator

b-mehta commented Aug 12, 2022

We discussed this offline, but for the sake of a record, the equivalence PartialFun ≌ Pointed isn't useful to transfer the monoidal structure, as the equivalence doesn't give you the nice monoidal structure unfortunately (in other words the correct monoidal structure on both sides means that the equivalence isn't a monoidal one)

src/category_theory/category/PartialFun.lean Outdated Show resolved Hide resolved
src/category_theory/category/Pointed.lean Outdated Show resolved Hide resolved
src/category_theory/category/Pointed.lean Show resolved Hide resolved
@kim-em kim-em requested a review from a team as a code owner November 7, 2022 04:06
@kim-em
Copy link
Collaborator

kim-em commented Nov 7, 2022

Seems to have been a spurious CI failure, and I couldn't re-run failed jobs, so I've merge master to restart CI.

@kim-em
Copy link
Collaborator

kim-em commented Nov 7, 2022

bors d+

@bors
Copy link

bors bot commented Nov 7, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 7, 2022
@YaelDillies
Copy link
Collaborator Author

Let me just say that since Bhavik's last review we figured out that this isn't the usual literature tensor operation on Pointed. Rather, it should be the "smash sum", the wedge from algebraic topology. I have it on a branch, so I can update this PR to use this instead, but then what should I do with the material in this PR?

@kim-em kim-em added awaiting-review The author would like community review of the PR not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 and removed delegated The PR author may merge after reviewing final suggestions. labels Jul 16, 2023
@kim-em
Copy link
Collaborator

kim-em commented Jul 30, 2023

Options:

  • Just drop this PR, if it isn't needed for something else you're doing, and this can be revisited in Mathlib when needed.
  • Merge as is, adding a note that this is the Cartesian monoidal structure, rather than the smash monoidal structure.

I'm inclined to drop: this construction would probably be better done as defining PointedObject for an arbitrary category with a terminal object, in any case.

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 17, 2023
@YaelDillies YaelDillies deleted the Pointed_monoidal branch November 12, 2023 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting-author A reviewer has asked the author a question or requested changes not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants