Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments about what is in scope for mathlib #526

Open
wants to merge 4 commits into
base: lean4
Choose a base branch
from

Conversation

kbuzzard
Copy link
Member

I think it would be slightly nicer to have a link to say "here is a big list of projects which depend on mathlib, please consider joining them", but right now this is waiting on leanprover/reservoir#49 . For now, I just link to the reservoir home page.

Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is generally a good change, so let's get this in!
I have 2 comments.

@fpvandoorn
Copy link
Member

Actually, a third comment: Your discussion is only relevant when adding completely new things to Mathlib, while the page is about any Mathlib contributions (including small fixes or single-lemma additions). So it should be made clear that your new section doesn't always apply (and maybe the section should be later?)

@kbuzzard
Copy link
Member Author

I have added "One example of such a repository is the combinatorial game
theory repository." (lines 48-49) when referring to the possibility of a standalone
repo depending on mathlib. But I am not aware of a link to this repo yet.
Should I remove this comment? Should I add the FLT repo or Carleson as examples?
These are a bit different because for both repos I can imagine some of the material
being upstreamed to mathlib, where with CGT we seem to have made a decision to
keep the repo separate.

@PatrickMassot
Copy link
Member

I think the link is https://github.com/YaelDillies/add-combi but of course you should check with Yaël before writing anything about that project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants