-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments about what is in scope for mathlib #526
base: lean4
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is generally a good change, so let's get this in!
I have 2 comments.
Actually, a third comment: Your discussion is only relevant when adding completely new things to Mathlib, while the page is about any Mathlib contributions (including small fixes or single-lemma additions). So it should be made clear that your new section doesn't always apply (and maybe the section should be later?) |
I have added "One example of such a repository is the combinatorial game |
I think the link is https://github.com/YaelDillies/add-combi but of course you should check with Yaël before writing anything about that project. |
I think it would be slightly nicer to have a link to say "here is a big list of projects which depend on mathlib, please consider joining them", but right now this is waiting on leanprover/reservoir#49 . For now, I just link to the reservoir home page.