Stop trimming '!' and '?' from tactic name. Fixes #299

[tautastic]

Stop trimming '!' and '?' from tactic name. Fixes #299. I have used main as the base branch since I don't know how to test on dev since the editor is not working on dev.

[joneugster]

That would be the way to do this, unless one would actually work with fully-qualified tactic names, in which case one could use the stuff underlying @[tactic_alt].

Also, it's probably worth thinking for a second if there are any cases where having something like simp? around would actually be desirable.

Anyways, I would like to wait with this for a moment, until dev is a bit more ready.

[TentativeConvert]

What would the fix proposed here actually do?

I’d say the ideal behaviour would be that simp? and apply? are treated like any other tactic, i.e. that it is left to the game developer to decide whether to make them available and/or visible or not, and that the game developer can make this choice independent of their choice for the cousins simp and apply. I fully agree that there may be cases where having simp? around would be desirable.

[joneugster]

True, and since we do have NewHiddenTactic for a while now, there is actually a way to add simp? without polluting the inventory 👍

[tautastic]

What would the fix proposed here actually do?

The proposed fix treats apply, apply? and apply! all as distinct tactics. You can enable or disable each one seperatly, and like Jon said you can enable apply? and apply! with NewHiddenTactic, this would result in the same user experience as before (you see only apply in your inventory but you can use apply? and apply!)

[TentativeConvert]

Thanks for clarifying! (I’ll leave it to @joneugster to merge when dev is ready.)