Fixes universe levels in Chapter 03 "Expressions" #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Universe level levelOne specified for Nat. Should be levelZero
adomasbaliuka
changed the title
Julian
reviewed
Aug 28, 2024
| mkAppN (.const ``List.map [levelOne, levelOne]) | ||
| #[nat, nat, addOne, .app (.const ``List.nil [levelOne]) nat] | ||
| mkAppN (.const ``List.map [levelZero, levelZero]) | ||
| #[nat, nat, addOne, .app (.const ``List.nil [levelZero]) nat] |
There was a problem hiding this comment.
This makes the universe output differ from what's shown below a few lines down on line 304:
-- @List.map.{1, 1} Nat Nat (fun x => Nat.add x 1) (@List.nil.{1} Nat) : List.{1} Nat
I fully defer to the Zulip thread that this change is right though -- can you just update that line so its output now has the right universes in it as well, and then this should be good to merge.
There was a problem hiding this comment.
Sorry about missing this and great you noticed! Updated.
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universe level
levelOnespecified for Nat. Should belevelZeroSee zulip discussion